Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create capture-process-snapshot.yml #833

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Create capture-process-snapshot.yml #833

merged 2 commits into from
Oct 9, 2023

Conversation

mr-tz
Copy link
Collaborator

@mr-tz mr-tz commented Oct 1, 2023

closes #527

williballenthin
williballenthin approved these changes Oct 1, 2023
View reviewed changes
nursery/capture-process-snapshot.yml Outdated
@@ -0,0 +1,10 @@
rule:
meta:
name: capture process snapshot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you think of any way to make this name a little more descriptive? like what kind of snapshot?

perhaps "capture process memory snapshot"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's multiple information that can be queried, see https://learn.microsoft.com/en-us/windows/win32/api/processsnapshot/ne-processsnapshot-pss_capture_flags, so I suggest data?!

@mr-tz mr-tz merged commit 216b30a into master Oct 9, 2023
3 checks passed
@mr-tz mr-tz deleted the mr-tz-patch-3 branch October 9, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process snapshot
2 participants
@mr-tz @williballenthin